Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model download path, codecov token and dependency path #67

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

Briancbn
Copy link
Member

@Briancbn Briancbn commented Feb 7, 2024

Key changes

  • Fix model download path
  • Fix codecov token
  • Use ros-industrial version of epd_onnxruntime_vendor

Signed-off-by: Chen Bainian <[email protected]>

Fixed broken CI due to problematic python library versions on pip
@Briancbn Briancbn changed the title Draft: Fix model download path, codecov token and dependency path Fix model download path, codecov token and dependency path Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8b9379) 80.50% compared to head (fd2c9f4) 76.75%.
Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   80.50%   76.75%   -3.75%     
==========================================
  Files          12       10       -2     
  Lines        1795     1355     -440     
==========================================
- Hits         1445     1040     -405     
+ Misses        350      315      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chen Bainian <[email protected]>
Signed-off-by: Chen Bainian <[email protected]>
@Briancbn
Copy link
Member Author

Briancbn commented Feb 7, 2024

@gavanderhoorn I renewed the codecov token and put the new one to repository secret. I also activated the codecov for this repo. Please let me know if this is ok with you?

@carlowiesse carlowiesse merged commit 88db293 into master Feb 7, 2024
9 checks passed
@Briancbn Briancbn deleted the feature/fix-models-download branch February 8, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants